Coder
test install profiles files
Posted August 31st, 2008 by douggreenI am developing an install pofile and I would like to check the coding style with coder module. There are no options to check install profiles at the moment.
file_save_upload rule needs testing
Posted August 30th, 2008 by douggreenI think that we should be #never instead of #not. Could someone verify and/or test this. Thanks!
Skip positive $form_state warning when used within a form_error()
Posted August 30th, 2008 by douggreenI think that we should skip the rule "use $form_state['values'] instead, which is where the values are stored after a submit" when the $form is used within a form_error().
Duplicate FAPI redirect rule?
Posted August 30th, 2008 by douggreen array( '#type' => 'regex', '#function' => '_confirm_submit$', '#value' => 'return [\'"]',
Write Rule security check for missing db_rewrite_sql on SELECT FROM {node}
Posted August 29th, 2008 by douggreenLIVE FROM DRUPALCON SZEGED. This idea came out of a session that Ken Rickards gave on node_access.
When you do a "SELECT FROM {node}", you should typically also wrap this in db_rewrite_sql. Since this is a security issue, but not a hard and fast rule, the rule should say something like "you are probably doing something wrong."
Create SimpleTest for the Coder SQL Review
Posted August 28th, 2008 by douggreenNow that #281399: Create Simpletest for the Coder 6.x Style Review has been committed, we need tests written for each of the 4 reviews. This task is a DROP task for creating the coder_sql.test file.
Create SimpleTest for the Coder Comment Review
Posted August 28th, 2008 by douggreenNow that #281399: Create Simpletest for the Coder 6.x Style Review has been committed, we need tests written for each of the 4 reviews. This task is a DROP task for creating the coder_comment.test file.
Create SimpleTest for the Coder 6.x Upgrade Review
Posted August 28th, 2008 by douggreenNow that #281399: Create Simpletest for the Coder 6.x Style Review has been committed, we need tests written for each of the 4 reviews. This task is a DROP task for creating the coder_6x.test file.