The Coder Documentation is missing an example on how to define a callback function, and how it works.

Hi,
Take the example code:
$string = t('Some text !my_link  foo bar wibble', array('!my_link' => l('Coder module', 'http://drupal.org/project/coder'))),

Hi,
We have a check in the i18n reviews that ensures there are no leading or trailing spaces in the string provided to t(). We should add the same check to other functions which do translation, including format_plural(), watchdog() and also menu items' titles and descriptions.
Cheers,
Stella

Hi,
Coding standards recommend use of single quotes instead of double quotes. This means you often end up with lines of code like:
$string = t('It doesn\'t match.');

Hi,
A false positive is generated for lines like:
'titleUser' => t('Your rating') .': ',
The error given is "The $string argument to t() should not begin or end with a space.".

Occasionally when I'm working on a module, Coder gives me errors that are not accurate. This usually happens with either PHP's string functions (which, in many cases, are faster than the drupal_ versions) or when dynamically building SQL queries (and a safe string is inserted into a query using %sinstead of '%s').

Hi,
Does Coder have functionality to review translations in .po-files? The Swedish translation team discussed this (in Swedish) and we are looking for a module to use and Coder might be that project as it already has the UI already written.

I think that hiding the selection form in the fieldset can be confusing to users. Does this patch improve the usability of the coder selection form?

This was generated by running the 5.x-6.x upgrade review on imagefield.module
#
Line 183: hook no longer exists, use hook_form_alter() to swap your own validation handler (Drupal Docs)
$db_info = content_database_info($field);
#
severity: criticalLine 231: hook no longer exists, use hook_form_alter() to swap your own validation handler (Drupal Docs)

In Drupal 5 and before, nobody should call a theme() function in a hook_menu(), because it would initialize the theme system too early and prevent dynamic modification of the theme (for example in the block administration interface).